Please fix the forgegradle problem and support for Scriptapi1 in b74
-
-
@CzechHek It is odd that the "update" of ForgeGradle would cause this issue, but I'll look into it. The SRGs are loaded from external source and I mean, minecraft itself is always the same, but maybe something we depend on has changed.
We did fork the ForgeGradle to make sure it does not go down anymore.
https://github.com/CCBlueX/ForgeGradle
This is why I hate working on 1.8 things. Everything is just outdated af and does not even exist anymore.But still does not explain why ForgeGradle should affect our remapper.
It seems AbstractJavaLinkerTransformer is not being registered anymore which causes the remapper not being injected into Nashorn.
-
It seems AbstractJavaLinkerTransformer is not being registered anymore which causes the remapper not being injected into Nashorn.
fixed.
No errors while Animations module is turned on.and is working fine (ofc cannot show cuz pic and not gif)
-
@kawaiinekololis said in Please fix the forgegradle problem and support for Scriptapi1 in b74:
@ybyyby_-awa How about you tell me what is not working?
Made an issue about this 7 months ago, saying that Nashorn or remapper doesn't work since ForgeGradle update causing things such as mc.thePlayer to be undefined.
https://github.com/CCBlueX/LiquidBounce/issues/817
Duplicate of mine post: https://github.com/CCBlueX/LiquidBounce/issues/823
So it had NOTHING to do with ForgeGradle what I expected, but someone accidently removed the transformers for AntiForge and the JS remapper. I still know that some people had issues when joining servers with AntiForge enabled, yeah, that was probably the reason.
@CzechHek @ybyyby_-awa Please try https://github.com/CCBlueX/LiquidBounce/commit/8e464765e5d906a3e8cd0ad780add68f73101d89
-
So it had NOTHING to do with ForgeGradle what I expected, but someone accidently removed the transformers for AntiForge and the JS remapper. I still know that some people had issues when joining servers with AntiForge enabled, yeah, that was probably the reason.
@CzechHek @ybyyby_-awa Please try https://github.com/CCBlueX/LiquidBounce/commit/8e464765e5d906a3e8cd0ad780add68f73101d89
@kawaiinekololis Yeah sir you still saying absolutely right
-
So it had NOTHING to do with ForgeGradle what I expected, but someone accidently removed the transformers for AntiForge and the JS remapper. I still know that some people had issues when joining servers with AntiForge enabled, yeah, that was probably the reason.
@CzechHek @ybyyby_-awa Please try https://github.com/CCBlueX/LiquidBounce/commit/8e464765e5d906a3e8cd0ad780add68f73101d89
https://github.com/CCBlueX/LiquidBounce/commit/313184df0f874ed6550888410fb9aabf4c2af07a
https://github.com/CCBlueX/LiquidBounce/compare/b74...b75However, I have decided to make this a hotfix update due to the critical issue with the ScriptAPI. Sorry for the inconvenience
Tested:
https://youtu.be/vwfVMoh-RjM -
https://github.com/CCBlueX/LiquidBounce/commit/313184df0f874ed6550888410fb9aabf4c2af07a
https://github.com/CCBlueX/LiquidBounce/compare/b74...b75However, I have decided to make this a hotfix update due to the critical issue with the ScriptAPI. Sorry for the inconvenience
Tested:
https://youtu.be/vwfVMoh-RjM@kawaiinekololis Thank you for fixing the ScriptAPI, however, the Microsoft login still doesn't work even after this update. Now it correctly redirects to http://localhost:1919/login?code=....... but this site fails because of empty response and then connection refused. LB keeps logging in and when you click on cancel, it crashes.
Log (crash report): https://pastebin.com/raw/LHwb9aAs
(latest.log https://pastebin.com/raw/9WYyjxSJ) -
It seems AbstractJavaLinkerTransformer is not being registered anymore which causes the remapper not being injected into Nashorn.
@kawaiinekololis Thanks for repairing! Also about "we need to work for free"
You may have misunderstood it (hey, my English is not good, maybe I have a problem with my expression)
I mean I need a lot of work to develop api conversion tools
Sorry,Please forgive me for being impolite hahahaha
Anyway! Thanks for repairing!!!!!!!!!!!!!!!!!!
I love you! -
@kawaiinekololis Thank you for fixing the ScriptAPI, however, the Microsoft login still doesn't work even after this update. Now it correctly redirects to http://localhost:1919/login?code=....... but this site fails because of empty response and then connection refused. LB keeps logging in and when you click on cancel, it crashes.
Log (crash report): https://pastebin.com/raw/LHwb9aAs
(latest.log https://pastebin.com/raw/9WYyjxSJ)